Revert "Upgrade expansion jar to java17"#38965
Conversation
This reverts commit b3a62ee.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts a previous upgrade to Java 17 for the expansion service. The change is intended to address compatibility issues, specifically InaccessibleObjectException, encountered during presubmit testing. Future updates to Java 17 will be handled on a per-test basis rather than as a global default. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request downgrades the Java version from 17 to 11 across several configurations, including the GitHub Actions setup environment action, the expansion service Dockerfile, and the Java IO expansion service build configuration. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This reverts commit b3a62ee.
This reverts commit b3a62ee.
2 participants
Reverts #38931
Fix
InaccessibleObjectExceptionseen in presubmit testsWhen rolling forward, do not change the default in setup-environment action but use
java_version: 17 11in individual tests, like what we did in https://github.com/apache/beam/pull/35232/changes#diff-4eb1051f5356e9447cc88403c921bc6b329d5f34a3ca02325b253515bce9dec4